generated from cybozu-go/neco-template
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency libs & newer mysql and k8s #676
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takara9
force-pushed
the
update-for-k8s-1.28-No10
branch
from
May 16, 2024 04:10
d8131fd
to
e0ad613
Compare
takara9
force-pushed
the
update-for-k8s-1.28-No10
branch
from
May 20, 2024 05:57
e74926c
to
21ec209
Compare
masa213f
requested changes
May 21, 2024
masa213f
requested changes
May 30, 2024
masa213f
requested changes
May 31, 2024
masa213f
requested changes
Jun 5, 2024
takara9
force-pushed
the
update-for-k8s-1.28-No10
branch
2 times, most recently
from
June 6, 2024 05:14
f0cda10
to
e3b1a64
Compare
masa213f
previously approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
takara9
force-pushed
the
update-for-k8s-1.28-No10
branch
2 times, most recently
from
June 6, 2024 07:31
35ce921
to
2c6569c
Compare
takara9
changed the title
Update dependency
Update dependency libs & newer mysql and k8s
Jun 6, 2024
takara9
force-pushed
the
update-for-k8s-1.28-No10
branch
from
June 6, 2024 07:33
2c6569c
to
9a32b80
Compare
masa213f
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
takara9
force-pushed
the
update-for-k8s-1.28-No10
branch
from
June 6, 2024 09:19
03f1aed
to
a5913e6
Compare
run contorller-gen and add new crd files update k8s version in build-mysql-container update dependency tool in Makefiles update Ubuntu 22.04 under .github/workflow Add support ver in README parent 496bfb6 author Maho Takara <[email protected]> 1716173837 +0000 committer Maho Takara <[email protected]> 1716184596 +0000 parent 496bfb6 author Maho Takara <[email protected]> 1716173837 +0000 committer Maho Takara <[email protected]> 1716184398 +0000 Down greade support ver k8s 1.27 - 1.29 run contorller-gen and add new crd files update Ubuntu 22.04 under .github/workflow fix conflict fix conflict fix unwnated marge fix conflict update for review comment update go modules update go api update go api fix miss version fix lib miss version update go mod update go mod change s3 module Add AWS S3 region update S3 param update s3 test update grpc api update for formatter report update CRD go k8s api libs 0.29.5 update CRD Remove config.WithRegion() Add environment env AWS_REGION Add AWS_REGION in test case change for review commnet change for gofmt error Revice explanation of AWS S3 edit for review comment fix error fix error of lint resolve conflict check for pd Delete unnecessary comment and space
takara9
force-pushed
the
update-for-k8s-1.28-No10
branch
from
June 6, 2024 23:58
a5913e6
to
5ba29aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable change:
Due to an update of the
github.com/aws/aws-sdk-go-v2
library, users must specify the region of the bucket in theirBackupPolicy
if thebucketConfig.backendType
iss3
or not specified. If the region is not specified, the backup/restore job will crash.ref: aws/aws-sdk-go-v2#2502
Dependencies:
Additional Support :